From: Richard Hansen <rhansen@rhansen.org>
Date: Thu, 20 Feb 2025 23:43:49 +0000 (-0800)
Subject: automake: add missing AC_MSG_RESULT calls to AM_SANITY_CHECK.
X-Git-Tag: v1.17.90~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=32b3cfa5fe94917da9b03f66b4ef083daeeca6b6;p=thirdparty%2Fautomake.git

automake: add missing AC_MSG_RESULT calls to AM_SANITY_CHECK.

From https://bugs.gnu.org/76448 (automake-patches).

* m4/sanity.m4 (AM_SANITY_CHECK): Call AC_MSG_RESULT before erroring
out so that a complete line is printed to stdout before the error
message is written to stderr.
* NEWS: mention this.
* THANKS: add Richard.
---

diff --git a/NEWS b/NEWS
index 22bd6a585..7856d31a3 100644
--- a/NEWS
+++ b/NEWS
@@ -16,8 +16,10 @@ New in 1.x:
 * Bugs fixed
 
   - Do not make Perl warnings fatal, per Perl's recommendation.
+    (https://lists.gnu.org/archive/html/automake/2025-01/msg00003.html)
 
   - Avoid Perl 5.41.8+ precedence warning for use of !!.
+    (https://lists.gnu.org/archive/html/automake/2025-01/msg00000.html)
 
   - The py-compile script once again does nothing (successfully) if the
     PYTHON environment variable is set to ":", or anything that isn't a
@@ -28,6 +30,9 @@ New in 1.x:
   - The compile script is more robust to Windows configurations;
     specifically, avoiding double-path translation on MSYS. (bug#75939)
 
+  - AM_SANITY_CHECK outputs a "no" for failure before fatal errors.
+    (bug#76448)
+
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 New in 1.17:
diff --git a/THANKS b/THANKS
index 7f3bdd470..50fbc18d5 100644
--- a/THANKS
+++ b/THANKS
@@ -442,6 +442,7 @@ Tim Mooney                      mooney@dogbert.cc.ndsu.NoDak.edu
 Tim Retout                      diocles@debian.org
 Tim Rice                        tim@multitalents.net
 Tim Van Holder                  tim.van.holder@pandora.be
+Richard Hansen                  rhansen@rhansen.org
 Tobias Hansen                   thansen@debian.org
 Tom Epperly                     tepperly@llnl.gov
 Tom Rini                        tom_rini@mentor.com
diff --git a/m4/sanity.m4 b/m4/sanity.m4
index 53538a873..be4b16113 100644
--- a/m4/sanity.m4
+++ b/m4/sanity.m4
@@ -169,10 +169,12 @@ am_lf='
 '
 case `pwd` in
   *[[\\\"\#\$\&\'\`$am_lf]]*)
+    AC_MSG_RESULT([no])
     AC_MSG_ERROR([unsafe absolute working directory name]);;
 esac
 case $srcdir in
   *[[\\\"\#\$\&\'\`$am_lf\ \	]]*)
+    AC_MSG_RESULT([no])
     AC_MSG_ERROR([unsafe srcdir value: '$srcdir']);;
 esac