From: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Date: Tue, 12 Aug 2025 00:26:52 +0000 (+1200)
Subject: python:samba: Raise an exception if we can’t parse a Markdown operation
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=32bfbc788d2fd161569f2ac3c192667a3cd196a9;p=thirdparty%2Fsamba.git

python:samba: Raise an exception if we can’t parse a Markdown operation

Otherwise we would continue with the wrong GUID and filename.

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/python/samba/ms_forest_updates_markdown.py b/python/samba/ms_forest_updates_markdown.py
index 0a0d2111a72..12a2041459a 100644
--- a/python/samba/ms_forest_updates_markdown.py
+++ b/python/samba/ms_forest_updates_markdown.py
@@ -253,10 +253,11 @@ def read_ms_markdown(in_file, out_folder=None, out_dict=None):
         if updates:
             for update in updates[2:]:
                 output = re.match(r'Operation (\d+): {(.*)}', update[0])
-                if output:
-                    # print output.group(1), output.group(2)
-                    guid = output.group(2)
-                    filename = "%s-{%s}.ldif" % (output.group(1).zfill(4), guid)
+                if not output:
+                    raise Exception(update)
+
+                guid = output.group(2)
+                filename = "%s-{%s}.ldif" % (output.group(1).zfill(4), guid)
 
                 found = False