From: Volker Lendecke <vl@samba.org>
Date: Sun, 24 Nov 2024 11:05:39 +0000 (+0100)
Subject: smbd: TALLOC_FREE(sd) where it was allocated
X-Git-Tag: tdb-1.4.13~440
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=32c492e8516ba17ad7e411e24169bf4e5498aed7;p=thirdparty%2Fsamba.git

smbd: TALLOC_FREE(sd) where it was allocated

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index e61b50b3801..b87b74988ae 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -198,8 +198,6 @@ static NTSTATUS smbd_check_access_rights_sd(
 		}
 	}
 
-	TALLOC_FREE(sd);
-
 	if (NT_STATUS_IS_OK(status) ||
 	    !NT_STATUS_EQUAL(status, NT_STATUS_ACCESS_DENIED))
 	{
@@ -327,13 +325,15 @@ NTSTATUS smbd_check_access_rights_fsp(struct files_struct *dirfsp,
 		return status;
 	}
 
-	return smbd_check_access_rights_sd(fsp->conn,
-					   dirfsp,
-					   fsp->fsp_name,
-					   sd,
-					   use_privs,
-					   access_mask,
-					   do_not_check_mask);
+	status = smbd_check_access_rights_sd(fsp->conn,
+					     dirfsp,
+					     fsp->fsp_name,
+					     sd,
+					     use_privs,
+					     access_mask,
+					     do_not_check_mask);
+	TALLOC_FREE(sd);
+	return status;
 }
 
 /*