From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Date: Thu, 17 Oct 2024 14:11:10 +0000 (+0300)
Subject: PCI: Simplify pci_read_bridge_bases() logic
X-Git-Tag: v6.13-rc1~66^2~26^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=32ec7b362d904c1e67f8e64524fb0b6c43d5c9c2;p=thirdparty%2Fkernel%2Flinux.git

PCI: Simplify pci_read_bridge_bases() logic

Use reverse logic combined with return and continue to significantly
reduce indentation level in pci_read_bridge_bases().

Link: https://lore.kernel.org/r/20241017141111.44612-3-ilpo.jarvinen@linux.intel.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 4243b1e6ece26..f9524b90bdbcc 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -543,14 +543,15 @@ void pci_read_bridge_bases(struct pci_bus *child)
 	pci_read_bridge_mmio(child->self, child->resource[1], false);
 	pci_read_bridge_mmio_pref(child->self, child->resource[2], false);
 
-	if (dev->transparent) {
-		pci_bus_for_each_resource(child->parent, res) {
-			if (res && res->flags) {
-				pci_bus_add_resource(child, res);
-				pci_info(dev, "  bridge window %pR (subtractive decode)\n",
-					   res);
-			}
-		}
+	if (!dev->transparent)
+		return;
+
+	pci_bus_for_each_resource(child->parent, res) {
+		if (!res || !res->flags)
+			continue;
+
+		pci_bus_add_resource(child, res);
+		pci_info(dev, "  bridge window %pR (subtractive decode)\n", res);
 	}
 }