From: Érico Nogueira <ericonr@disroot.org>
Date: Tue, 4 May 2021 01:51:50 +0000 (-0300)
Subject: misc: use _fitoa_word to implement __fd_to_filename.
X-Git-Tag: glibc-2.34~481
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=330001202ada53dcf3de81f95edc2616f8d75c68;p=thirdparty%2Fglibc.git

misc: use _fitoa_word to implement __fd_to_filename.

In a default build for x86_64, size decreased by 24 bytes:
1883294 to 1883270.

Aditionally, avoids repeating the number printing logic in multiple
places.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
---

diff --git a/misc/fd_to_filename.c b/misc/fd_to_filename.c
index 86a1a1acc29..20c20149037 100644
--- a/misc/fd_to_filename.c
+++ b/misc/fd_to_filename.c
@@ -20,6 +20,7 @@
 
 #include <assert.h>
 #include <string.h>
+#include <_itoa.h>
 
 char *
 __fd_to_filename (int descriptor, struct fd_to_filename *storage)
@@ -28,11 +29,7 @@ __fd_to_filename (int descriptor, struct fd_to_filename *storage)
 
   char *p = mempcpy (storage->buffer, FD_TO_FILENAME_PREFIX,
                      strlen (FD_TO_FILENAME_PREFIX));
+  *_fitoa_word (descriptor, p, 10, 0) = '\0';
 
-  for (int d = descriptor; p++, (d /= 10) != 0; )
-    continue;
-  *p = '\0';
-  for (int d = descriptor; *--p = '0' + d % 10, (d /= 10) != 0; )
-    continue;
   return storage->buffer;
 }