From: Daniel Stenberg <daniel@haxx.se>
Date: Sat, 20 Sep 2025 09:25:38 +0000 (+0200)
Subject: libssh: error on bad chgrp number
X-Git-Tag: rc-8_17_0-2~438
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=335d16e944c86a0f7d9c52e3932e1f0ccca39feb;p=thirdparty%2Fcurl.git

libssh: error on bad chgrp number

To avoid it continuing with a zero gid.

Reported in Joshua's sarif data

Closes #18629
---

diff --git a/lib/vssh/libssh.c b/lib/vssh/libssh.c
index 2554468c4b..be8336ad0a 100644
--- a/lib/vssh/libssh.c
+++ b/lib/vssh/libssh.c
@@ -1808,10 +1808,7 @@ static int myssh_in_SFTP_QUOTE_STAT(struct Curl_easy *data,
   if(!strncmp(cmd, "chgrp", 5)) {
     const char *p = sshc->quote_path1;
     curl_off_t gid;
-    (void)curlx_str_number(&p, &gid, UINT_MAX);
-    sshc->quote_attrs->gid = (uint32_t)gid;
-    if(sshc->quote_attrs->gid == 0 && !ISDIGIT(sshc->quote_path1[0]) &&
-       !sshc->acceptfail) {
+    if(curlx_str_number(&p, &gid, UINT_MAX)) {
       Curl_safefree(sshc->quote_path1);
       Curl_safefree(sshc->quote_path2);
       failf(data, "Syntax error: chgrp gid not a number");
@@ -1820,6 +1817,7 @@ static int myssh_in_SFTP_QUOTE_STAT(struct Curl_easy *data,
       sshc->actualcode = CURLE_QUOTE_ERROR;
       return SSH_NO_ERROR;
     }
+    sshc->quote_attrs->gid = (uint32_t)gid;
     sshc->quote_attrs->flags |= SSH_FILEXFER_ATTR_UIDGID;
   }
   else if(!strncmp(cmd, "chmod", 5)) {