From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Tue, 5 Oct 2021 12:42:25 +0000 (+0200)
Subject: BUG/MAJOR: xprt-quic: do not queue qc timer if not set
X-Git-Tag: v2.5-dev9~39
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=336f6fd964e9304a2b810e21d72650e2c12aecd2;p=thirdparty%2Fhaproxy.git

BUG/MAJOR: xprt-quic: do not queue qc timer if not set

Do not queue the pto/loss-detection timer if set to TICK_ETERNITY. This
usage is invalid with the scheduler and cause a BUG_ON trigger.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index 8501e3fafe..cee93229ef 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -647,7 +647,8 @@ static inline void qc_set_timer(struct ssl_sock_ctx *ctx)
 	if (tick_isset(pto))
 		qc->timer = pto;
  out:
-	task_schedule(qc->timer_task, qc->timer);
+	if (qc->timer != TICK_ETERNITY)
+		task_schedule(qc->timer_task, qc->timer);
 	TRACE_LEAVE(QUIC_EV_CONN_STIMER, ctx->conn, pktns);
 }