From: Dr. David von Oheimb <David.von.Oheimb@siemens.com>
Date: Sat, 17 Sep 2022 19:54:07 +0000 (+0200)
Subject: OSSL_CMP_ITAV_set0.pod: fix formatting nits, update example
X-Git-Tag: openssl-3.2.0-alpha1~1675
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=33a73e33dce1e62613d67471ba8b68afe01166c0;p=thirdparty%2Fopenssl.git

OSSL_CMP_ITAV_set0.pod: fix formatting nits, update example

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from https://github.com/openssl/openssl/pull/19230)
---

diff --git a/doc/man3/OSSL_CMP_ITAV_set0.pod b/doc/man3/OSSL_CMP_ITAV_set0.pod
index 593af73fcdd..5dd9bcb266f 100644
--- a/doc/man3/OSSL_CMP_ITAV_set0.pod
+++ b/doc/man3/OSSL_CMP_ITAV_set0.pod
@@ -11,20 +11,18 @@ OSSL_CMP_ITAV_push0_stack_item
 
 =head1 SYNOPSIS
 
-  #include <openssl/cmp.h>
-  OSSL_CMP_ITAV *OSSL_CMP_ITAV_create(ASN1_OBJECT *type, ASN1_TYPE *value);
-  void OSSL_CMP_ITAV_set0(OSSL_CMP_ITAV *itav, ASN1_OBJECT *type,
-                          ASN1_TYPE *value);
-  ASN1_OBJECT *OSSL_CMP_ITAV_get0_type(const OSSL_CMP_ITAV *itav);
-  ASN1_TYPE *OSSL_CMP_ITAV_get0_value(const OSSL_CMP_ITAV *itav);
+ #include <openssl/cmp.h>
 
-  int OSSL_CMP_ITAV_push0_stack_item(STACK_OF(OSSL_CMP_ITAV) **itav_sk_p,
-                                     OSSL_CMP_ITAV *itav);
+ OSSL_CMP_ITAV *OSSL_CMP_ITAV_create(ASN1_OBJECT *type, ASN1_TYPE *value);
+ void OSSL_CMP_ITAV_set0(OSSL_CMP_ITAV *itav, ASN1_OBJECT *type,
+                         ASN1_TYPE *value);
+ ASN1_OBJECT *OSSL_CMP_ITAV_get0_type(const OSSL_CMP_ITAV *itav);
+ ASN1_TYPE *OSSL_CMP_ITAV_get0_value(const OSSL_CMP_ITAV *itav);
+ int OSSL_CMP_ITAV_push0_stack_item(STACK_OF(OSSL_CMP_ITAV) **itav_sk_p,
+                                    OSSL_CMP_ITAV *itav);
 
 =head1 DESCRIPTION
 
-Certificate Management Protocol (CMP, RFC 4210) extension to OpenSSL
-
 ITAV is short for InfoTypeAndValue. This type is defined in RFC 4210
 section 5.3.19 and Appendix F. It is used at various places in CMP messages,
 e.g., in the generalInfo PKIHeader field, to hold a key-value pair.
@@ -81,10 +79,9 @@ included in the requests' PKIHeader's genInfo field.
     OSSL_CMP_ITAV *itav = OSSL_CMP_ITAV_create(type, val);
     if (itav == NULL) ...
 
-    OSSL_CMP_CTX *ctx = OSSL_CMP_CTX_new();
-    if (ctx == NULL || !OSSL_CMP_CTX_geninfo_push0_ITAV(ctx, itav)) {
+    if (!OSSL_CMP_CTX_push0_geninfo_ITAV(ctx, itav)) {
         OSSL_CMP_ITAV_free(itav); /* also frees type and val */
-        goto err;
+        ...
     }
 
     ...