From: Dan Carpenter Date: Wed, 17 Feb 2021 07:45:25 +0000 (+0300) Subject: bpf: Fix a warning message in mark_ptr_not_null_reg() X-Git-Tag: v5.12-rc3~39^2~93^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=33ccec5fd740d0d5b78b77846f76eb5b4feb4327;p=thirdparty%2Fkernel%2Flinux.git bpf: Fix a warning message in mark_ptr_not_null_reg() The WARN_ON() argument is a condition, not an error message. So this code will print a stack trace but will not print the warning message. Fix that and also change it to only WARN_ONCE(). Fixes: 4ddb74165ae5 ("bpf: Extract nullable reg type conversion into a helper function") Signed-off-by: Dan Carpenter Signed-off-by: Daniel Borkmann Link: https://lore.kernel.org/bpf/YCzJlV3hnF%2Ft1Pk4@mwanda --- diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 1dda9d81f12c5..3d34ba492d461 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -1120,7 +1120,7 @@ static void mark_ptr_not_null_reg(struct bpf_reg_state *reg) reg->type = PTR_TO_RDWR_BUF; break; default: - WARN_ON("unknown nullable register type"); + WARN_ONCE(1, "unknown nullable register type"); } }