From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Thu, 8 May 2025 06:26:25 +0000 (+0300)
Subject: crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()
X-Git-Tag: v6.16-rc1~206^2~40
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=33cd93435cea665b24ca3f9b3d6af42afb3ba7bc;p=thirdparty%2Fkernel%2Flinux.git

crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()

The pcim_iomap_region() returns error pointers.  It doesn't return NULL
pointers.  Update the check to match.

Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c b/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c
index 2531c337e0dd2..132e265016213 100644
--- a/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c
+++ b/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c
@@ -156,8 +156,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 		/* Map 64-bit PCIe BAR */
 		bar->virt_addr = pcim_iomap_region(pdev, bar_map[i], pci_name(pdev));
-		if (!bar->virt_addr) {
-			ret = -ENOMEM;
+		if (IS_ERR(bar->virt_addr)) {
+			ret = PTR_ERR(bar->virt_addr);
 			return dev_err_probe(dev, ret, "Failed to ioremap PCI region.\n");
 		}
 	}