From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 11 Mar 2017 16:33:07 +0000 (+1300)
Subject: Add move semantics to Security::ServerOptions and Security::PeerOptions
X-Git-Tag: M-staged-PR71~222
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=33de409eb3e7cecd56cdee81fbb918e3090d52ef;p=thirdparty%2Fsquid.git

Add move semantics to Security::ServerOptions and Security::PeerOptions

This apparently will make the clear() operators faster as they no longer
have to data-copy.

  Detected by Coverity Scan. Issues 1364734 and 1364737
---

diff --git a/src/security/PeerOptions.h b/src/security/PeerOptions.h
index cbe848ecd6..72cf2904d1 100644
--- a/src/security/PeerOptions.h
+++ b/src/security/PeerOptions.h
@@ -25,6 +25,8 @@ public:
     PeerOptions();
     PeerOptions(const PeerOptions &) = default;
     PeerOptions &operator =(const PeerOptions &) = default;
+    PeerOptions(PeerOptions &&) = default;
+    PeerOptions &operator =(PeerOptions &&) = default;
     virtual ~PeerOptions() {}
 
     /// parse a TLS squid.conf option
diff --git a/src/security/ServerOptions.h b/src/security/ServerOptions.h
index cb79f47f7a..6072d97399 100644
--- a/src/security/ServerOptions.h
+++ b/src/security/ServerOptions.h
@@ -24,6 +24,10 @@ public:
         // is more secure to have only a small set of trusted CA.
         flags.tlsDefaultCa.defaultTo(false);
     }
+    ServerOptions(const ServerOptions &) = default;
+    ServerOptions &operator =(const ServerOptions &) = default;
+    ServerOptions(ServerOptions &&) = default;
+    ServerOptions &operator =(ServerOptions &&) = default;
     virtual ~ServerOptions() = default;
 
     /* Security::PeerOptions API */