From: Han-Wen Nienhuys <hanwen@google.com>
Date: Thu, 20 Jan 2022 15:12:06 +0000 (+0000)
Subject: reftable: all xxx_free() functions accept NULL arguments
X-Git-Tag: v2.36.0-rc0~154^2~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=33e922432016f614327bcf5624c084b7c02fe9c3;p=thirdparty%2Fgit.git

reftable: all xxx_free() functions accept NULL arguments

This fixes NULL derefs in error paths. Spotted by Coverity.

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/reftable/reader.c b/reftable/reader.c
index 35781593a2..272378ed1d 100644
--- a/reftable/reader.c
+++ b/reftable/reader.c
@@ -646,6 +646,8 @@ int reftable_new_reader(struct reftable_reader **p,
 
 void reftable_reader_free(struct reftable_reader *r)
 {
+	if (!r)
+		return;
 	reader_close(r);
 	reftable_free(r);
 }
diff --git a/reftable/writer.c b/reftable/writer.c
index 3ca721e9f6..9fd24fa93c 100644
--- a/reftable/writer.c
+++ b/reftable/writer.c
@@ -150,6 +150,8 @@ void reftable_writer_set_limits(struct reftable_writer *w, uint64_t min,
 
 void reftable_writer_free(struct reftable_writer *w)
 {
+	if (!w)
+		return;
 	reftable_free(w->block);
 	reftable_free(w);
 }