From: Daniel Henrique Barboza <danielhb413@gmail.com>
Date: Mon, 16 Nov 2020 20:34:00 +0000 (-0300)
Subject: domain_conf.c: use g_autofree in 'dev' in virDomainDefParseBootXML()
X-Git-Tag: v7.0.0-rc1~377
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=340db6e54940ab7bd9f56f99a4e53faf838016bd;p=thirdparty%2Flibvirt.git

domain_conf.c: use g_autofree in 'dev' in virDomainDefParseBootXML()

This spares us of 2 explicit VIR_FREE() calls.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b1534dcc1e..4b80024f77 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -18907,7 +18907,7 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt,
 
     for (i = 0; i < n && i < VIR_DOMAIN_BOOT_LAST; i++) {
         int val;
-        char *dev = virXMLPropString(nodes[i], "dev");
+        g_autofree char *dev = virXMLPropString(nodes[i], "dev");
         if (!dev) {
             virReportError(VIR_ERR_INTERNAL_ERROR,
                            "%s", _("missing boot device"));
@@ -18917,10 +18917,8 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt,
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("unknown boot device '%s'"),
                            dev);
-            VIR_FREE(dev);
             return -1;
         }
-        VIR_FREE(dev);
         def->os.bootDevs[def->os.nBootDevs++] = val;
     }