From: Willy Tarreau <w@1wt.eu>
Date: Fri, 11 Dec 2020 10:21:53 +0000 (+0100)
Subject: CLEANUP: connection: remove the unused conn_{stop,cond_update}_polling()
X-Git-Tag: v2.4-dev3~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=343d0356a5292a05b82ba514aec76e1e7bc6b8be;p=thirdparty%2Fhaproxy.git

CLEANUP: connection: remove the unused conn_{stop,cond_update}_polling()

These functions are not used anymore and were quite confusing given that
their names reflected their original role and not the current ones. Let's
kill them before they inspire anyone.
---

diff --git a/include/haproxy/connection.h b/include/haproxy/connection.h
index 72ba1796af..1986d3bd87 100644
--- a/include/haproxy/connection.h
+++ b/include/haproxy/connection.h
@@ -170,22 +170,6 @@ static inline void conn_stop_tracking(struct connection *conn)
 	conn->flags &= ~CO_FL_XPRT_TRACKED;
 }
 
-/* Stop all polling on the fd. This might be used when an error is encountered
- * for example.
- */
-static inline void conn_stop_polling(struct connection *c)
-{
-	if (conn_ctrl_ready(c))
-		fd_stop_both(c->handle.fd);
-}
-
-/* Stops polling in case of error on the connection. */
-static inline void conn_cond_update_polling(struct connection *c)
-{
-	if (unlikely(c->flags & CO_FL_ERROR))
-		conn_stop_polling(c);
-}
-
 /* read shutdown, called from the rcv_buf/rcv_pipe handlers when
  * detecting an end of connection.
  */