From: Gary Lockyer <gary@catalyst.net.nz>
Date: Wed, 27 May 2026 21:39:30 +0000 (+1200)
Subject: build: enable tautological-compare errors
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3485f58ea1c2a4013b0ab60c1ddee0faa4eb3eea;p=thirdparty%2Fsamba.git

build: enable tautological-compare errors

Now that all the warnings have been removed, and as they did in fact reveal
real issues lets make it an error.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=16092

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/buildtools/wafsamba/samba_autoconf.py b/buildtools/wafsamba/samba_autoconf.py
index d7f7baa334d..ddd56efa2e1 100644
--- a/buildtools/wafsamba/samba_autoconf.py
+++ b/buildtools/wafsamba/samba_autoconf.py
@@ -850,7 +850,6 @@ int main(void) {
 
         if not Options.options.disable_warnings_as_errors:
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Werror -Wno-error=deprecated-declarations', testflags=True)
-            conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=tautological-compare', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=cast-align', testflags=True)
 
     if Options.options.fatal_errors: