From: Christian Brauner Date: Mon, 25 Nov 2024 14:10:20 +0000 (+0100) Subject: cgroup: avoid pointless cred reference count bump X-Git-Tag: v6.14-rc1~214^2~1^2~5 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=34ab26fb6b2a70ae6b22fc3880bc6d8b68579564;p=thirdparty%2Fkernel%2Flinux.git cgroup: avoid pointless cred reference count bump of->file->f_cred already holds a reference count that is stable during the operation. Link: https://lore.kernel.org/r/20241125-work-cred-v2-24-68b9d38bb5b2@kernel.org Reviewed-by: Jeff Layton Reviewed-by: Jens Axboe Signed-off-by: Christian Brauner --- diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 1a94e8b154bee..d9061bd55436b 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -5216,11 +5216,11 @@ static ssize_t __cgroup_procs_write(struct kernfs_open_file *of, char *buf, * permissions using the credentials from file open to protect against * inherited fd attacks. */ - saved_cred = override_creds(get_new_cred(of->file->f_cred)); + saved_cred = override_creds(of->file->f_cred); ret = cgroup_attach_permissions(src_cgrp, dst_cgrp, of->file->f_path.dentry->d_sb, threadgroup, ctx->ns); - put_cred(revert_creds(saved_cred)); + revert_creds(saved_cred); if (ret) goto out_finish;