From: Tim Kientzle <kientzle@acm.org>
Date: Sat, 1 Mar 2025 17:06:31 +0000 (-0800)
Subject: Avoid unreachable code in this test (#2528)
X-Git-Tag: v3.8.0~70
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3512329ba9a06a7360601f195c5013c3161f5e70;p=thirdparty%2Flibarchive.git

Avoid unreachable code in this test (#2528)

As remarked in #2521, this test has unreachable code on Windows, which
triggers a build failure in development due to warnings-as-errors.
(Release versions should not have warnings-as-errors.)
---

diff --git a/tar/test/test_option_ignore_zeros.c b/tar/test/test_option_ignore_zeros.c
index 31e0dd940..453e8a090 100644
--- a/tar/test/test_option_ignore_zeros.c
+++ b/tar/test/test_option_ignore_zeros.c
@@ -76,8 +76,7 @@ DEFINE_TEST(test_option_ignore_zeros_mode_c)
 	// bsdtar.exe: b: Can't translate uname '(null)' to UTF-8
 	skipping("TODO: figure out why this test fails on github workflows with MSVC");
 	return;
-#endif
-
+#else
 	if (make_files())
 		return;
 
@@ -97,6 +96,7 @@ DEFINE_TEST(test_option_ignore_zeros_mode_c)
 	assertEqualFile("out/a", "in/a");
 	assertEqualFile("out/b", "in/b");
 	assertEqualFile("out/c", "in/c");
+#endif
 }
 
 static void