From: Xiao Liang Date: Wed, 19 Feb 2025 12:50:30 +0000 (+0800) Subject: ieee802154: 6lowpan: Validate link netns in newlink() of rtnl_link_ops X-Git-Tag: v6.15-rc1~160^2~252^2~9 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3533717581dd72c9559b508e0feaede426d825aa;p=thirdparty%2Fkernel%2Flinux.git ieee802154: 6lowpan: Validate link netns in newlink() of rtnl_link_ops Device denoted by IFLA_LINK is in link_net (IFLA_LINK_NETNSID) or source netns by design, but 6lowpan uses dev_net. Note dev->netns_local is set to true and currently link_net is implemented via a netns change. These together effectively reject IFLA_LINK_NETNSID. This patch adds a validation to ensure link_net is either NULL or identical to dev_net. Thus it would be fine to continue using dev_net when rtnetlink core begins to create devices directly in target netns. Signed-off-by: Xiao Liang Reviewed-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20250219125039.18024-5-shaw.leon@gmail.com Signed-off-by: Jakub Kicinski --- diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c index 704bf9e3f0975..ee318d46817d4 100644 --- a/net/ieee802154/6lowpan/core.c +++ b/net/ieee802154/6lowpan/core.c @@ -143,6 +143,8 @@ static int lowpan_newlink(struct net_device *ldev, if (!tb[IFLA_LINK]) return -EINVAL; + if (params->link_net && !net_eq(params->link_net, dev_net(ldev))) + return -EINVAL; /* find and hold wpan device */ wdev = dev_get_by_index(dev_net(ldev), nla_get_u32(tb[IFLA_LINK])); if (!wdev)