From: drh <drh@noemail.net>
Date: Wed, 1 Feb 2017 01:34:15 +0000 (+0000)
Subject: Improved comments on the statGet() implementation in ANALYZE.  No changes
X-Git-Tag: version-3.17.0~47
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=35497fccbe358dda7b95e1a4c109020725877f0b;p=thirdparty%2Fsqlite.git

Improved comments on the statGet() implementation in ANALYZE.  No changes
to code.

FossilOrigin-Name: 9663eea2a16bb4eec71476d307a3722a768308c3
---

diff --git a/manifest b/manifest
index cb6735cb6d..cd07701b23 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C R-TREE\soptimization:\sunwrap\sthe\scoordinate\sdecode\sloop\sin\nrtreeCallbackConstraint().
-D 2017-01-31T21:22:03.245
+C Improved\scomments\son\sthe\sstatGet()\simplementation\sin\sANALYZE.\s\sNo\schanges\nto\scode.
+D 2017-02-01T01:34:15.043
 F Makefile.in 5f415e7867296d678fed2e6779aea10c1318b4bc
 F Makefile.linux-gcc 7bc79876b875010e8c8f9502eb935ca92aa3c434
 F Makefile.msc b8ca53350ae545e3562403d5da2a69cec79308da
@@ -328,7 +328,7 @@ F sqlite.pc.in 42b7bf0d02e08b9e77734a47798d1a55a9e0716b
 F sqlite3.1 fc7ad8990fc8409983309bb80de8c811a7506786
 F sqlite3.pc.in 48fed132e7cb71ab676105d2a4dc77127d8c1f3a
 F src/alter.c 3b23977620ce9662ac54443f65b87ba996e36121
-F src/analyze.c 317dbaf31c16050582b09bf4f323b4e0f1813251
+F src/analyze.c ac7a5d7e3cee07d074697904e00e4a8ab7b2b4f5
 F src/attach.c 8c476f8bd5d2afe11d925f890d30e527e5b0ce43
 F src/auth.c 930b376a9c56998557367e6f7f8aaeac82a2a792
 F src/backup.c faf17e60b43233c214aae6a8179d24503a61e83b
@@ -1549,7 +1549,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P 85dddf2b453b8afaf1f485b96084d31e22f97dda
-R 80f20a76d631de95caa5095989ae297f
+P 0bf7b51896ec441f62490964c7a44a3c75c6b7e2
+R bb550435b988e435dcc2fd1779602487
 U drh
-Z d89e7b06786861fbe2704ca06b1411f8
+Z 36c251bda157d6101f2fb97842697f89
diff --git a/manifest.uuid b/manifest.uuid
index 0415fad4fb..1081a26f59 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-0bf7b51896ec441f62490964c7a44a3c75c6b7e2
\ No newline at end of file
+9663eea2a16bb4eec71476d307a3722a768308c3
\ No newline at end of file
diff --git a/src/analyze.c b/src/analyze.c
index c079132f4a..890ae7c3b2 100644
--- a/src/analyze.c
+++ b/src/analyze.c
@@ -797,6 +797,12 @@ static const FuncDef statPushFuncdef = {
 ** The content to returned is determined by the parameter J
 ** which is one of the STAT_GET_xxxx values defined above.
 **
+** The stat_get(P,J) function is not available to generic SQL.  It is
+** inserted as part of a manually constructed bytecode program.  (See
+** the callStatGet() routine below.)  It is guaranteed that the P
+** parameter will always be a poiner to a Stat4Accum object, never a
+** NULL.
+**
 ** If neither STAT3 nor STAT4 are enabled, then J is always
 ** STAT_GET_STAT1 and is hence omitted and this routine becomes
 ** a one-parameter function, stat_get(P), that always returns the