From: Selva Nair Date: Tue, 21 Nov 2017 01:43:25 +0000 (-0500) Subject: Correct the declaration of handle in 'struct openvpn_plugin_args_open_return' X-Git-Tag: v2.4.7~36 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=359e66bcb17c856a74cada9136ae1b8f411a2493;p=thirdparty%2Fopenvpn.git Correct the declaration of handle in 'struct openvpn_plugin_args_open_return' - This is an opaque pointer so the change should not affect existing plugins. But it makes the code consistent and clears up the documentation as the handle pointer is treated as of type "openvpn_plugin_handle_t" in the rest of the code. Signed-off-by: Selva Nair Acked-by: Antonio Quartulli Message-Id: <1511228605-23207-1-git-send-email-selva.nair@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15908.html Signed-off-by: Gert Doering (cherry picked from commit a2f43c2d6f086e7aa8b6160793f0c462ee9d6aa7) --- diff --git a/include/openvpn-plugin.h.in b/include/openvpn-plugin.h.in index 8614b6116..a19ab18f0 100644 --- a/include/openvpn-plugin.h.in +++ b/include/openvpn-plugin.h.in @@ -355,7 +355,7 @@ struct openvpn_plugin_args_open_in * type_mask = OPENVPN_PLUGIN_MASK(OPENVPN_PLUGIN_CLIENT_CONNECT) * | OPENVPN_PLUGIN_MASK(OPENVPN_PLUGIN_CLIENT_DISCONNECT) * - * *handle : Pointer to a global plug-in context, created by the plug-in. This pointer + * handle : Pointer to a global plug-in context, created by the plug-in. This pointer * is passed on to the other plug-in calls. * * return_list : used to return data back to OpenVPN. @@ -364,7 +364,7 @@ struct openvpn_plugin_args_open_in struct openvpn_plugin_args_open_return { int type_mask; - openvpn_plugin_handle_t *handle; + openvpn_plugin_handle_t handle; struct openvpn_plugin_string_list **return_list; }; @@ -386,9 +386,9 @@ struct openvpn_plugin_args_open_return * these variables are not actually written to the "official" * environmental variable store of the process. * - * *handle : Pointer to a global plug-in context, created by the plug-in's openvpn_plugin_open_v3(). + * handle : Pointer to a global plug-in context, created by the plug-in's openvpn_plugin_open_v3(). * - * *per_client_context : the per-client context pointer which was returned by + * per_client_context : the per-client context pointer which was returned by * openvpn_plugin_client_constructor_v1, if defined. * * current_cert_depth : Certificate depth of the certificate being passed over (only if compiled with ENABLE_CRYPTO defined)