From: daiwei <daiwei521@126.com>
Date: Wed, 11 Dec 2024 14:03:21 +0000 (+0800)
Subject: chore: only cache return value for setStyle and setDynamicProps
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=360fd4cd1e895269b00ef76863ca687d3dad81ee;p=thirdparty%2Fvuejs%2Fcore.git

chore: only cache return value for setStyle and setDynamicProps

The value of setStyle and setDynamicProps may be a reactive object
---

diff --git a/packages/compiler-vapor/src/generators/prop.ts b/packages/compiler-vapor/src/generators/prop.ts
index bce64af402..35716537dd 100644
--- a/packages/compiler-vapor/src/generators/prop.ts
+++ b/packages/compiler-vapor/src/generators/prop.ts
@@ -1,5 +1,4 @@
 import {
-  BindingTypes,
   NewlineType,
   type SimpleExpressionNode,
   isSimpleIdentifier,
@@ -236,6 +235,8 @@ const helpersNeedCachedReturnValue = [
   'setDynamicProps',
 ]
 
+const helpersNoNeedCachedDeps = ['setStyle', 'setDynamicProps']
+
 function processPropValues(
   context: CodegenContext,
   helperName: string,
@@ -247,28 +248,26 @@ function processPropValues(
   // e.g. _foo === _ctx.foo && (_prev_foo = _setStyle(...))
   let shouldWrapInParentheses: boolean = false
   let prevValueName
-  const needReturnValue = helpersNeedCachedReturnValue.includes(helperName)
   if (shouldCacheRenderEffectDeps()) {
-    const { declareNames, operations, identifiers } = processingRenderEffect!
-    // if render effect rely on any reactive object, it should not cache
-    const canCache = identifiers.every(name =>
-      isBindingCacheable(context, name),
-    )
-    processValues(context, values, canCache)
+    const { declareNames, operations } = processingRenderEffect!
+    const needReturnValue = helpersNeedCachedReturnValue.includes(helperName)
+    processValues(context, values, !needReturnValue)
     // if the operation needs to cache the return value and has multiple declareNames,
     // combine them into a single name as the return value name.
     if (declareNames.size > 0 && needReturnValue) {
       const names = [...declareNames]
       prevValueName =
         declareNames.size === 1 ? `_prev${names[0]}` : names.join('')
-      if (!canCache) {
-        declareNames.clear()
-        processingRenderEffect!.earlyCheckExps = []
-      }
       declareNames.add(prevValueName)
     }
-    shouldWrapInParentheses = operations.length === 1 && canCache
+    shouldWrapInParentheses = operations.length === 1
+
+    if (helpersNoNeedCachedDeps.includes(helperName)) {
+      declareNames.clear()
+      processingRenderEffect!.earlyCheckExps = []
+    }
   }
+
   return { prevValueName, shouldWrapInParentheses }
 }
 
@@ -330,14 +329,3 @@ function processValue(
     return [...new Set(earlyCheckExps)]
   }
 }
-
-function isBindingCacheable(context: CodegenContext, name: string): boolean {
-  const {
-    options: { bindingMetadata },
-  } = context
-  const bindingType = bindingMetadata[name]
-  return (
-    bindingType !== BindingTypes.SETUP_REACTIVE_CONST &&
-    bindingType !== BindingTypes.SETUP_CONST
-  )
-}