From: Fred Morcos <fred.morcos@open-xchange.com>
Date: Thu, 23 Nov 2023 18:39:01 +0000 (+0100)
Subject: calidns: Fix lints in sendmsg call
X-Git-Tag: rec-5.0.0-rc1~23^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=361abedb3892a8fb1e6caa16f4af3d56cfcbc4ed;p=thirdparty%2Fpdns.git

calidns: Fix lints in sendmsg call
---

diff --git a/pdns/calidns.cc b/pdns/calidns.cc
index dbfdbd65c2..920a4df88c 100644
--- a/pdns/calidns.cc
+++ b/pdns/calidns.cc
@@ -167,7 +167,6 @@ static void sendPackets(const vector<std::unique_ptr<Socket>>& sockets, const ve
     cmsgbuf_aligned cbuf;
   };
   vector<unique_ptr<Unit> > units;
-  int ret;
 
   for(const auto& p : packets) {
     count++;
@@ -179,11 +178,14 @@ static void sendPackets(const vector<std::unique_ptr<Socket>>& sockets, const ve
     }
 
     fillMSGHdr(&u.msgh, &u.iov, nullptr, 0, (char*)&(*p)[0], p->size(), &dest);
-    if((ret=sendmsg(sockets[count % sockets.size()]->getHandle(),
-		    &u.msgh, 0)))
-      if(ret < 0)
-	      unixDie("sendmsg");
 
+    auto socketHandle = sockets[count % sockets.size()]->getHandle();
+    ssize_t sendmsgRet = sendmsg(socketHandle, &u.msgh, 0);
+    if (sendmsgRet != 0) {
+      if (sendmsgRet < 0) {
+        unixDie("sendmsg");
+      }
+    }
 
     if(!(count%burst)) {
       nBursts++;