From: Charalampos Mitrodimas <charmitro@posteo.net>
Date: Wed, 20 Nov 2024 12:55:50 +0000 (+0200)
Subject: hlink: Fix function pointer cast in qsort()
X-Git-Tag: v3.4.0~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=36212021f0b8f64d28a5713f6b485f97857187f1;p=thirdparty%2Frsync.git

hlink: Fix function pointer cast in qsort()

Replace unsafe generic function pointer cast with proper type cast for
qsort() comparison function. This fixes a potential type mismatch
warning without changing the behavior.

Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net>
---

diff --git a/hlink.c b/hlink.c
index 20291f26..2c14407a 100644
--- a/hlink.c
+++ b/hlink.c
@@ -117,7 +117,7 @@ static void match_gnums(int32 *ndx_list, int ndx_count)
 	struct ht_int32_node *node = NULL;
 	int32 gnum, gnum_next;
 
-	qsort(ndx_list, ndx_count, sizeof ndx_list[0], (int (*)()) hlink_compare_gnum);
+	qsort(ndx_list, ndx_count, sizeof ndx_list[0], (int (*)(const void*, const void*))hlink_compare_gnum);
 
 	for (from = 0; from < ndx_count; from++) {
 		file = hlink_flist->sorted[ndx_list[from]];