From: Joseph Myers <joseph@codesourcery.com>
Date: Fri, 15 Feb 2019 13:44:17 +0000 (+0000)
Subject: Fix implicit-fallthrough warnings in tst-setjmp.c.
X-Git-Tag: glibc-2.30~349
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=365f05c7a5f16aaaec06465ab6c89247c66b4574;p=thirdparty%2Fglibc.git

Fix implicit-fallthrough warnings in tst-setjmp.c.

Building the testsuite with -Wextra (together with
-Wno-cast-function-type -Wno-clobbered -Wno-expansion-to-defined
-Wno-missing-field-initializers -Wno-old-style-declaration
-Wno-shift-negative-value -Wno-sign-compare -Wno-type-limits
-Wno-unused-parameter, which reflect the set of -Wextra warnings for
which glibc itself is not currently clean on x86_64) showed up
implicit-fallthrough warnings in tst-setjmp.c.  Those warnings appear
to be false positives, arising from a function "jump" that calls
longjmp not itself being marked as noreturn; thus, this patch adds the
noreturn marking to that function to fix the warnings.

Tested for x86_64.

	* setjmp/tst-setjmp.c (jump): Use __attribute__ ((__noreturn__)).
---

diff --git a/ChangeLog b/ChangeLog
index d3560ade54b..0c45e9a8524 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2019-02-15  Joseph Myers  <joseph@codesourcery.com>
+
+	* setjmp/tst-setjmp.c (jump): Use __attribute__ ((__noreturn__)).
+
 2019-02-14  Jan Kratochvil <jan.kratochvil@redhat.com>
 
 	* scripts/test_printers_common.py: Set TERM to a known harmless
diff --git a/setjmp/tst-setjmp.c b/setjmp/tst-setjmp.c
index e83e896ebea..b377393ecf1 100644
--- a/setjmp/tst-setjmp.c
+++ b/setjmp/tst-setjmp.c
@@ -22,7 +22,7 @@
 static jmp_buf env;
 static int last_value = -1, lose = 0;
 
-static void
+static __attribute__ ((__noreturn__)) void
 jump (int val)
 {
   longjmp (env, val);