From: dtucker@openbsd.org <dtucker@openbsd.org>
Date: Wed, 8 Mar 2023 06:21:32 +0000 (+0000)
Subject: upstream: Plug mem leak. Coverity CID 405196, ok djm@
X-Git-Tag: V_9_3_P1~20
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=36c6c3eff5e4a669ff414b9daf85f919666e8e03;p=thirdparty%2Fopenssh-portable.git

upstream: Plug mem leak. Coverity CID 405196, ok djm@

OpenBSD-Commit-ID: 175f09349387c292f626da68f65f334faaa085f2
---

diff --git a/sftp.c b/sftp.c
index 3a2525462..4a3774421 100644
--- a/sftp.c
+++ b/sftp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sftp.c,v 1.227 2023/03/08 04:43:12 guenther Exp $ */
+/* $OpenBSD: sftp.c,v 1.228 2023/03/08 06:21:32 dtucker Exp $ */
 /*
  * Copyright (c) 2001-2004 Damien Miller <djm@openbsd.org>
  *
@@ -1997,7 +1997,9 @@ complete_match(EditLine *el, struct sftp_conn *conn, char *remote_path,
 
 	memset(&g, 0, sizeof(g));
 	if (remote != LOCAL) {
-		tmp = make_absolute_pwd_glob(tmp, remote_path);
+		tmp2 = make_absolute_pwd_glob(tmp, remote_path);
+		free(tmp);
+		tmp = tmp2;
 		remote_glob(conn, tmp, GLOB_DOOFFS|GLOB_MARK, NULL, &g);
 	} else
 		glob(tmp, GLOB_DOOFFS|GLOB_MARK, NULL, &g);