From: Wouter Wijngaards Date: Fri, 20 May 2016 06:35:49 +0000 (+0000) Subject: - Fix #766: dns64 should synthesize results on timeout/errors. X-Git-Tag: release-1.5.9rc1~26 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=36dc04734e89955c5e6d51628501aec57c649af9;p=thirdparty%2Funbound.git - Fix #766: dns64 should synthesize results on timeout/errors. git-svn-id: file:///svn/unbound/trunk@3721 be551aaa-1e26-0410-a405-d3ace91eadb9 --- diff --git a/dns64/dns64.c b/dns64/dns64.c index 0de3f6643..2fde67841 100644 --- a/dns64/dns64.c +++ b/dns64/dns64.c @@ -521,13 +521,14 @@ handle_event_moddone(struct module_qstate* qstate, int id) * - An internal query. * - A query for a record type other than AAAA. * - CD FLAG was set on querier - * - An AAAA query for which an error was returned. + * - An AAAA query for which an error was returned.(qstate.return_rcode) + * -> treated as servfail thus synthesize (sec 5.1.3 6147), thus + * synthesize in (sec 5.1.2 of RFC6147). * - A successful AAAA query with an answer. */ if ( (enum dns64_qstate)qstate->minfo[id] == DNS64_INTERNAL_QUERY || qstate->qinfo.qtype != LDNS_RR_TYPE_AAAA || (qstate->query_flags & BIT_CD) - || qstate->return_rcode != LDNS_RCODE_NOERROR || (qstate->return_msg && qstate->return_msg->rep && reply_find_answer_rrset(&qstate->qinfo, diff --git a/doc/Changelog b/doc/Changelog index cbc8c8970..0b50a169d 100644 --- a/doc/Changelog +++ b/doc/Changelog @@ -1,3 +1,6 @@ +19 May 2016: Wouter + - Fix #766: dns64 should synthesize results on timeout/errors. + 18 May 2016: Wouter - Fix #761: DNSSEC LAME false positive resolving nic.club.