From: George Burgess IV <gbiv@google.com>
Date: Wed, 23 Nov 2016 00:05:51 +0000 (-0800)
Subject: libxt_multiport: remove an unused variable
X-Git-Tag: v1.6.1~16
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=36e7d239dd721a60f9bf3191ae50e726c34ee50d;p=thirdparty%2Fiptables.git

libxt_multiport: remove an unused variable

Clang's static analyzer flagged the shift this patch removes as
shifting a garbage value. Looks like `m` isn't used at all anyway, so
we can simply remove it.

Signed-off-by: George Burgess IV <gbiv@google.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
---

diff --git a/extensions/libxt_multiport.c b/extensions/libxt_multiport.c
index 5c5cbe0f..07ad4cfd 100644
--- a/extensions/libxt_multiport.c
+++ b/extensions/libxt_multiport.c
@@ -108,7 +108,6 @@ parse_multi_ports_v1(const char *portstring,
 {
 	char *buffer, *cp, *next, *range;
 	unsigned int i;
-	uint16_t m;
 
 	buffer = strdup(portstring);
 	if (!buffer) xtables_error(OTHER_PROBLEM, "strdup failed");
@@ -133,7 +132,6 @@ parse_multi_ports_v1(const char *portstring,
 			if (multiinfo->ports[i-1] >= multiinfo->ports[i])
 				xtables_error(PARAMETER_PROBLEM,
 					   "invalid portrange specified");
-			m <<= 1;
 		}
  	}
 	multiinfo->count = i;