From: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Tue, 28 Oct 2025 05:41:48 +0000 (+0100)
Subject: target/arm/hvf: Mention hvf_inject_interrupts() must run on vCPU thread
X-Git-Tag: v10.2.0-rc1~28^2~18
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3747befb2a64ddd216ba01a4836100d7a4909fff;p=thirdparty%2Fqemu.git

target/arm/hvf: Mention hvf_inject_interrupts() must run on vCPU thread

Since hvf_inject_interrupts() calls hv_vcpu_set_pending_interrupt(),
which must run on a vCPU, it also must. Mention it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Mads Ynddal <mads@ynddal.dk>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---

diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
index ee04943b0f..0d8ff49ae1 100644
--- a/target/arm/hvf/hvf.c
+++ b/target/arm/hvf/hvf.c
@@ -1664,6 +1664,7 @@ static int hvf_sysreg_write(CPUState *cpu, uint32_t reg, uint64_t val)
     return 1;
 }
 
+/* Must be called by the owning thread */
 static int hvf_inject_interrupts(CPUState *cpu)
 {
     if (cpu_test_interrupt(cpu, CPU_INTERRUPT_FIQ)) {