From: Gustavo A. R. Silva Date: Fri, 20 Nov 2020 18:38:47 +0000 (-0600) Subject: rds: Fix fall-through warnings for Clang X-Git-Tag: v5.14-rc1~155^2~8 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3754fa747dc0fb41cd1fd9a79bcb442dfe6802b3;p=thirdparty%2Flinux.git rds: Fix fall-through warnings for Clang In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Reviewed-by: Håkon Bugge Signed-off-by: Gustavo A. R. Silva --- diff --git a/net/rds/tcp_connect.c b/net/rds/tcp_connect.c index 4e64598176b05..5461d77fff4f4 100644 --- a/net/rds/tcp_connect.c +++ b/net/rds/tcp_connect.c @@ -78,6 +78,7 @@ void rds_tcp_state_change(struct sock *sk) case TCP_CLOSE_WAIT: case TCP_CLOSE: rds_conn_path_drop(cp, false); + break; default: break; } diff --git a/net/rds/threads.c b/net/rds/threads.c index 32dc50f0a3031..1f424cbfcbb47 100644 --- a/net/rds/threads.c +++ b/net/rds/threads.c @@ -208,6 +208,7 @@ void rds_send_worker(struct work_struct *work) case -ENOMEM: rds_stats_inc(s_send_delayed_retry); queue_delayed_work(rds_wq, &cp->cp_send_w, 2); + break; default: break; } @@ -232,6 +233,7 @@ void rds_recv_worker(struct work_struct *work) case -ENOMEM: rds_stats_inc(s_recv_delayed_retry); queue_delayed_work(rds_wq, &cp->cp_recv_w, 2); + break; default: break; }