From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Mon, 28 Mar 2016 17:27:41 +0000 (-0300)
Subject: Fix minor leak in pg_dump for ACCESS METHOD.
X-Git-Tag: REL9_6_BETA1~371
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=37732a2555f109b09b7eedfc44a9de22e22268a4;p=thirdparty%2Fpostgresql.git

Fix minor leak in pg_dump for ACCESS METHOD.

Bug reported by Coverity.

Author: Michaël Paquier
---

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 77bf8acd9fb..077b37eb43d 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -11580,6 +11580,7 @@ dumpAccessMethod(Archive *fout, AccessMethodInfo *aminfo)
 		default:
 			write_msg(NULL, "WARNING: invalid type %c of access method %s\n",
 					  aminfo->amtype, qamname);
+			pg_free(qamname);
 			destroyPQExpBuffer(q);
 			destroyPQExpBuffer(delq);
 			destroyPQExpBuffer(labelq);
@@ -11609,7 +11610,7 @@ dumpAccessMethod(Archive *fout, AccessMethodInfo *aminfo)
 				NULL, "",
 				aminfo->dobj.catId, 0, aminfo->dobj.dumpId);
 
-	free(qamname);
+	pg_free(qamname);
 
 	destroyPQExpBuffer(q);
 	destroyPQExpBuffer(delq);