From: Federico Caselli <cfederico87@gmail.com>
Date: Wed, 22 Nov 2023 21:04:03 +0000 (+0100)
Subject: Fix pre-ping regression in old PyMySQL versions.
X-Git-Tag: rel_1_4_51~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3776694bd7d3d3877e2e6f6ad259e490b2f672a9;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Fix pre-ping regression in old PyMySQL versions.

Fixed regression introduced by the fix in ticket :ticket:`10492` when using
pool pre-ping with PyMySQL version older than 1.0.

Fixes: #10650
Change-Id: Ic0744c8b6f91cc39868e31c3bfddb8df20c7dfbb
---

diff --git a/doc/build/changelog/unreleased_14/10650.rst b/doc/build/changelog/unreleased_14/10650.rst
new file mode 100644
index 0000000000..dce6b4c75a
--- /dev/null
+++ b/doc/build/changelog/unreleased_14/10650.rst
@@ -0,0 +1,7 @@
+.. change::
+    :tags: bug, mysql
+    :tickets: 10650
+    :versions: 2.0.24
+
+    Fixed regression introduced by the fix in ticket :ticket:`10492` when using
+    pool pre-ping with PyMySQL version older than 1.0.
diff --git a/lib/sqlalchemy/dialects/mysql/pymysql.py b/lib/sqlalchemy/dialects/mysql/pymysql.py
index 26a03fa4c9..a08418096b 100644
--- a/lib/sqlalchemy/dialects/mysql/pymysql.py
+++ b/lib/sqlalchemy/dialects/mysql/pymysql.py
@@ -91,7 +91,9 @@ class MySQLDialect_pymysql(MySQLDialect_mysqldb):
         """  # noqa: E501
 
         try:
-            Connection = __import__("pymysql.connections").Connection
+            Connection = __import__(
+                "pymysql.connections"
+            ).connections.Connection
         except (ImportError, AttributeError):
             return True
         else: