From: Erlend E. Aasland <erlend@python.org>
Date: Mon, 27 Jan 2025 17:16:19 +0000 (+0100)
Subject: gh-129346: Handle allocation errors for SQLite aggregate context (#129347)
X-Git-Tag: v3.14.0a5~209
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=379ab856f59423c570333403a7d5d72f3ea82d52;p=thirdparty%2FPython%2Fcpython.git

gh-129346: Handle allocation errors for SQLite aggregate context (#129347)
---

diff --git a/Misc/NEWS.d/next/Library/2025-01-27-14-05-19.gh-issue-129346.gZRd3g.rst b/Misc/NEWS.d/next/Library/2025-01-27-14-05-19.gh-issue-129346.gZRd3g.rst
new file mode 100644
index 000000000000..b5377277f6c5
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2025-01-27-14-05-19.gh-issue-129346.gZRd3g.rst
@@ -0,0 +1,2 @@
+In :mod:`sqlite3`, handle out-of-memory when creating user-defined SQL
+functions.
diff --git a/Modules/_sqlite/connection.c b/Modules/_sqlite/connection.c
index fc03e4a085c1..62598ecc8641 100644
--- a/Modules/_sqlite/connection.c
+++ b/Modules/_sqlite/connection.c
@@ -958,6 +958,11 @@ step_callback(sqlite3_context *context, int argc, sqlite3_value **params)
     assert(ctx != NULL);
 
     aggregate_instance = (PyObject**)sqlite3_aggregate_context(context, sizeof(PyObject*));
+    if (aggregate_instance == NULL) {
+        (void)PyErr_NoMemory();
+        set_sqlite_error(context, "unable to allocate SQLite aggregate context");
+        goto error;
+    }
     if (*aggregate_instance == NULL) {
         *aggregate_instance = PyObject_CallNoArgs(ctx->callable);
         if (!*aggregate_instance) {