From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 28 Jan 2025 18:49:23 +0000 (+0100)
Subject: auth.idl: make sure ndr_{push,pull}_auth_SidAttr() is never used
X-Git-Tag: tevent-0.17.0~787
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=37bdab354cc2eae92a2ddc517b02616fbfe0b0c7;p=thirdparty%2Fsamba.git

auth.idl: make sure ndr_{push,pull}_auth_SidAttr() is never used

auth_SidAttr is currently not used for any IPC traffic,
with this change demonstrates that and makes sure it
stays that way.

It means we are free to change auth_SidAttr without the
need to change any ipc protocol version.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
---

diff --git a/librpc/idl/auth.idl b/librpc/idl/auth.idl
index ab5675ef8c5..214f48185f2 100644
--- a/librpc/idl/auth.idl
+++ b/librpc/idl/auth.idl
@@ -109,14 +109,14 @@ interface auth
 	 * resource groups and resource groups in other domains are always
 	 * discarded.
 	 */
-	typedef enum {
+	typedef [nopush,nopull] enum {
 		AUTH_GROUP_INCLUSION_INVALID = 0, /* require invalid values to be handled. */
 		AUTH_INCLUDE_RESOURCE_GROUPS = 2,
 		AUTH_INCLUDE_RESOURCE_GROUPS_COMPRESSED = 3,
 		AUTH_EXCLUDE_RESOURCE_GROUPS = 4
 	} auth_group_inclusion;
 
-	typedef [public] struct {
+	typedef [nopush,nopull] struct {
 		dom_sid sid;
 		security_GroupAttrs attrs;
 	} auth_SidAttr;
diff --git a/librpc/ndr/ndr_auth.c b/librpc/ndr/ndr_auth.c
index 0600586ed16..b60d8bff4b0 100644
--- a/librpc/ndr/ndr_auth.c
+++ b/librpc/ndr/ndr_auth.c
@@ -41,4 +41,16 @@ _PUBLIC_ enum ndr_err_code ndr_push_cli_credentials(struct ndr_push *ndr, ndr_fl
 	return ndr_push_pointer(ndr, ndr_flags, NULL);
 }
 
+_PUBLIC_ enum ndr_err_code ndr_push_auth_SidAttr(struct ndr_push *ndr, ndr_flags_type ndr_flags, const struct auth_SidAttr *r)
+{
+	return ndr_push_error(ndr,
+			      NDR_ERR_INVALID_POINTER,
+			      "ndr_push_auth_SidAttr not supported");
+}
 
+_PUBLIC_ enum ndr_err_code ndr_pull_auth_SidAttr(struct ndr_pull *ndr, ndr_flags_type ndr_flags, struct auth_SidAttr *r)
+{
+	return ndr_pull_error(ndr,
+			      NDR_ERR_INVALID_POINTER,
+			      "ndr_pull_auth_SidAttr not supported");
+}