From: Juerg Haefliger Date: Fri, 22 Feb 2019 20:53:50 +0000 (+0100) Subject: selftests/ftrace: Replace echo -e with printf X-Git-Tag: v5.1-rc1~95^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=37fb665b059edcd6ab87b1541402eef3dac91168;p=thirdparty%2Fkernel%2Flinux.git selftests/ftrace: Replace echo -e with printf echo -e is not POSIX. Depending on what /bin/sh is, we can get incorrect output like: $ -e -n [1] Basic trace file check $ -e [PASS] Fix that by using printf instead. Acked-by: Steven Rostedt (VMware) Acked-by: Masami Hiramatsu Signed-off-by: Juerg Haefliger Signed-off-by: Shuah Khan --- diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest index 75244db703310..2e5e66774dbbf 100755 --- a/tools/testing/selftests/ftrace/ftracetest +++ b/tools/testing/selftests/ftrace/ftracetest @@ -173,8 +173,13 @@ strip_esc() { } prlog() { # messages - echo -e "$@" - [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE + newline="\n" + if [ "$1" = "-n" ] ; then + newline= + shift + fi + printf "$*$newline" + [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE } catlog() { #file cat $1