From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sat, 23 Apr 2005 17:45:35 +0000 (+0000)
Subject: Recent changes got the sense of the notnull bit backwards in the 2.0
X-Git-Tag: REL8_1_0BETA1~956
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3842892492622a56577dea07be758cffa4501afa;p=thirdparty%2Fpostgresql.git

Recent changes got the sense of the notnull bit backwards in the 2.0
protocol output routines.  Mea culpa :-(.  Per report from Kris Jurka.
---

diff --git a/src/backend/access/common/printtup.c b/src/backend/access/common/printtup.c
index e78dc19a03f..d9dc2ae17fc 100644
--- a/src/backend/access/common/printtup.c
+++ b/src/backend/access/common/printtup.c
@@ -9,7 +9,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/access/common/printtup.c,v 1.88 2005/04/06 16:34:04 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/access/common/printtup.c,v 1.89 2005/04/23 17:45:35 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -402,7 +402,7 @@ printtup_20(TupleTableSlot *slot, DestReceiver *self)
 	k = 1 << 7;
 	for (i = 0; i < natts; ++i)
 	{
-		if (slot->tts_isnull[i])
+		if (!slot->tts_isnull[i])
 			j |= k;				/* set bit if not null */
 		k >>= 1;
 		if (k == 0)				/* end of byte? */
@@ -610,7 +610,7 @@ printtup_internal_20(TupleTableSlot *slot, DestReceiver *self)
 	k = 1 << 7;
 	for (i = 0; i < natts; ++i)
 	{
-		if (slot->tts_isnull[i])
+		if (!slot->tts_isnull[i])
 			j |= k;				/* set bit if not null */
 		k >>= 1;
 		if (k == 0)				/* end of byte? */