From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 15 Nov 2019 10:11:10 +0000 (+0100)
Subject: polkit-agent: don't use an inline function
X-Git-Tag: v244-rc1~46^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=385d581b7429f9d1d6d2826eac82e581468656f9;p=thirdparty%2Fsystemd.git

polkit-agent: don't use an inline function

This is long enough to just be a regular function, and is never called
in inner loops, let's hence just make this a plain function.
---

diff --git a/src/shared/spawn-polkit-agent.c b/src/shared/spawn-polkit-agent.c
index 180cb7964cf..4d6c0cae6ca 100644
--- a/src/shared/spawn-polkit-agent.c
+++ b/src/shared/spawn-polkit-agent.c
@@ -83,3 +83,16 @@ void polkit_agent_close(void) {
 }
 
 #endif
+
+int polkit_agent_open_if_enabled(BusTransport transport, bool ask_password) {
+
+        /* Open the polkit agent as a child process if necessary */
+
+        if (transport != BUS_TRANSPORT_LOCAL)
+                return 0;
+
+        if (!ask_password)
+                return 0;
+
+        return polkit_agent_open();
+}
diff --git a/src/shared/spawn-polkit-agent.h b/src/shared/spawn-polkit-agent.h
index 190b970b6f2..56b0175944e 100644
--- a/src/shared/spawn-polkit-agent.h
+++ b/src/shared/spawn-polkit-agent.h
@@ -1,22 +1,11 @@
 /* SPDX-License-Identifier: LGPL-2.1+ */
 #pragma once
 
+#include <stdbool.h>
+
 #include "bus-util.h"
 
 int polkit_agent_open(void);
 void polkit_agent_close(void);
 
-static inline int polkit_agent_open_if_enabled(
-                BusTransport transport,
-                bool ask_password) {
-
-        /* Open the polkit agent as a child process if necessary */
-
-        if (transport != BUS_TRANSPORT_LOCAL)
-                return 0;
-
-        if (!ask_password)
-                return 0;
-
-        return polkit_agent_open();
-}
+int polkit_agent_open_if_enabled(BusTransport transport, bool ask_password);