From: Viktor Szakats Date: Sun, 3 Aug 2025 20:14:02 +0000 (+0200) Subject: cmake: fix to restrict `SystemConfiguration` to macOS X-Git-Tag: curl-8_16_0~274 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=38672f2eafed9229b85de2307ebb647ad8820ead;p=thirdparty%2Fcurl.git cmake: fix to restrict `SystemConfiguration` to macOS Also fix indentation and tidy up to use `STREQUAL` when checking for Darwin. Reported-by: Waldemar Kornewald Fixes #18149 Regression from 739ef9804d8e1e9b4a8d2a610896babc62c5524b #13713 Closes #18153 --- diff --git a/CMakeLists.txt b/CMakeLists.txt index 7e3cfff3ce..c12d2bcc18 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -355,7 +355,7 @@ if(WIN32) endif() # Override to force-disable or force-enable the use of pkg-config. -if((UNIX AND NOT ANDROID AND (NOT APPLE OR CMAKE_SYSTEM_NAME MATCHES "Darwin")) OR +if((UNIX AND NOT ANDROID AND (NOT APPLE OR CMAKE_SYSTEM_NAME STREQUAL "Darwin")) OR VCPKG_TOOLCHAIN OR (MINGW AND NOT CMAKE_CROSSCOMPILING)) set(_curl_use_pkgconfig_default ON) @@ -653,7 +653,7 @@ if(ENABLE_IPV6) set(ENABLE_IPV6 OFF CACHE BOOL "Enable IPv6 support" FORCE) # Force the feature off as we use this name as guard macro endif() - if(APPLE AND NOT ENABLE_ARES) + if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND NOT ENABLE_ARES) set(_use_core_foundation_and_core_services ON) find_library(SYSTEMCONFIGURATION_FRAMEWORK NAMES "SystemConfiguration") diff --git a/m4/curl-sysconfig.m4 b/m4/curl-sysconfig.m4 index 3215e7d3db..f5ebe0391b 100644 --- a/m4/curl-sysconfig.m4 +++ b/m4/curl-sysconfig.m4 @@ -32,7 +32,7 @@ AC_MSG_CHECKING([whether to link macOS CoreFoundation, CoreServices, and SystemC #if TARGET_OS_MAC && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) return 0; #else - #error Not macOS + #error Not macOS #endif ]]) ],[