From: Amos Jeffries <squid3@treenet.co.nz>
Date: Mon, 11 Nov 2013 11:24:23 +0000 (-0700)
Subject: Fix possible NULL-dereference handling annotations
X-Git-Tag: SQUID_3_5_0_1~526
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=389b88c300d52d3b203cf117678e6392859a5f4d;p=thirdparty%2Fsquid.git

Fix possible NULL-dereference handling annotations

  Detected by Coverity Scan. Issue 1127088
---

diff --git a/src/auth/UserRequest.cc b/src/auth/UserRequest.cc
index d6b6bf1cab..d4bf5e6452 100644
--- a/src/auth/UserRequest.cc
+++ b/src/auth/UserRequest.cc
@@ -258,7 +258,7 @@ authTryGetUser(Auth::UserRequest::Pointer auth_user_request, ConnStateData * con
         res = conn->getAuth();
 
     // attach the credential notes from helper to the transaction
-    if (res != NULL && res->user() != NULL) {
+    if (request != NULL && res != NULL && res->user() != NULL) {
         // XXX: we have no access to the transaction / AccessLogEntry so cant SyncNotes().
         // workaround by using anything already set in HttpRequest
         // OR use new and rely on a later Sync copying these to AccessLogEntry