From: Christopher Faulet <cfaulet@haproxy.com>
Date: Fri, 22 Jul 2022 15:07:32 +0000 (+0200)
Subject: BUG/MINOR: backend: Fallback on RR algo if balance on source is impossible
X-Git-Tag: v2.7-dev3~71
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=38c53944cb3306e36f6d60764c15adb206aedfb3;p=thirdparty%2Fhaproxy.git

BUG/MINOR: backend: Fallback on RR algo if balance on source is impossible

If the loadbalancing is performed on the source IP address, an internal
error was returned on error. So for an applet on the client side (for
instance an SPOE applet) or for a client connected to a unix socket, an
internal error is returned.

However, when other LB algos fail, a fallback on round-robin is
performed. There is no reson to not do the same here.

This patch should fix the issue #1797. It must be backported to all
supported versions.
---

diff --git a/src/backend.c b/src/backend.c
index ce170af9f7..2ae76002b1 100644
--- a/src/backend.c
+++ b/src/backend.c
@@ -744,11 +744,6 @@ int assign_server(struct stream *s)
 							    (void *)&((struct sockaddr_in6 *)src)->sin6_addr,
 							    16, prev_srv);
 				}
-				else {
-					/* unknown IP family */
-					err = SRV_STATUS_INTERNAL;
-					goto out;
-				}
 				break;
 
 			case BE_LB_HASH_URI: