From: Simon Wang <wangchuanguo@inspur.com>
Date: Wed, 22 Jun 2022 03:19:23 +0000 (-0400)
Subject: bpf: Replace hard-coded 0 with BPF_K in check_alu_op
X-Git-Tag: v6.0-rc1~141^2~163^2~38
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=395e942d34a25824457da379baf434b5d6da4dcc;p=thirdparty%2Fkernel%2Flinux.git

bpf: Replace hard-coded 0 with BPF_K in check_alu_op

Enhance readability a bit.

Signed-off-by: Simon Wang <wangchuanguo@inspur.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20220622031923.65692-1-wangchuanguo@inspur.com
---

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index a20d7736a5b20..f228141c01c58 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -9096,7 +9096,7 @@ static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
 
 	if (opcode == BPF_END || opcode == BPF_NEG) {
 		if (opcode == BPF_NEG) {
-			if (BPF_SRC(insn->code) != 0 ||
+			if (BPF_SRC(insn->code) != BPF_K ||
 			    insn->src_reg != BPF_REG_0 ||
 			    insn->off != 0 || insn->imm != 0) {
 				verbose(env, "BPF_NEG uses reserved fields\n");