From: drh <drh@noemail.net>
Date: Sat, 15 Jan 2005 00:36:36 +0000 (+0000)
Subject: Improved coverage for insert.c. (CVS 2213)
X-Git-Tag: version-3.6.10~3939
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=39df51b2696608a930e1d5bed0e53d34a09d9d28;p=thirdparty%2Fsqlite.git

Improved coverage for insert.c. (CVS 2213)

FossilOrigin-Name: 997d8afff9b316aef4c5e2127c2207758ff4a703
---

diff --git a/manifest b/manifest
index e6cb2882c3..1c2b14f600 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Add\scomments\sto\sthe\snew\sbalance_quick()\sroutine.\s(CVS\s2212)
-D 2005-01-14T22:55:49
+C Improved\scoverage\sfor\sinsert.c.\s(CVS\s2213)
+D 2005-01-15T00:36:37
 F Makefile.in 6ce51dde6a8fe82fc12f20dec750572f6a19f56a
 F Makefile.linux-gcc a9e5a0d309fa7c38e7c14d3ecf7690879d3a5457
 F README a01693e454a00cc117967e3f9fdab2d4d52e9bc1
@@ -136,7 +136,7 @@ F test/index.test 1294997b4743007af57f8148c63ba14f07ad31ab
 F test/index2.test ed2409af110aa06ec0c9fedfa050031887c38707
 F test/insert.test 56f9c20c9adc8d707490c4ffa5d4daa94826ea03
 F test/insert2.test 0bb50ff999e35a21549d8ee5dc44db8ac24d31a7
-F test/insert3.test 421f6017ad268fcdba0b8ab56a2dff7265d3cf23
+F test/insert3.test fa7cb5b01709a1bca3e28c82c80c1d44386b3676
 F test/interrupt.test 5b4d8389e6cf2d01b94f87cfd02d9df1073bfb2d
 F test/intpkey.test b57cf5236fde1bd8cbc1388fa0c91908f6fd9194
 F test/ioerr.test fe51bacd7ffb83b9a0b70eceee3608dfd36371f6
@@ -269,7 +269,7 @@ F www/tclsqlite.tcl e73f8f8e5f20e8277619433f7970060ab01088fc
 F www/vdbe.tcl 095f106d93875c94b47367384ebc870517431618
 F www/version3.tcl 092a01f5ef430d2c4acc0ae558d74c4bb89638a0
 F www/whentouse.tcl c3b50d3ac31c54be2a1af9b488a89d22f1e6e746
-P c550d80c25ec88fceb20acabd00c21faa2d552f5
-R 11aa1732839148efceafec181a4aacf2
+P 183c42eac82b41da7905e44a43913f04acc46ade
+R a357aa122ea9a3e8dc5bb5808b1b049d
 U drh
-Z 125f4f4e919590f6f1ede4bc594f0cdf
+Z 599dc5adeb716baa4dcd266377de3b9f
diff --git a/manifest.uuid b/manifest.uuid
index 3580b5d9aa..afdfec5ea5 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-183c42eac82b41da7905e44a43913f04acc46ade
\ No newline at end of file
+997d8afff9b316aef4c5e2127c2207758ff4a703
\ No newline at end of file
diff --git a/test/insert3.test b/test/insert3.test
index 7e6153af9c..b505f637c2 100644
--- a/test/insert3.test
+++ b/test/insert3.test
@@ -11,11 +11,15 @@
 # This file implements regression tests for SQLite library.  The
 # focus of this file is testing corner cases of the INSERT statement.
 #
-# $Id: insert3.test,v 1.1 2005/01/14 01:22:01 drh Exp $
+# $Id: insert3.test,v 1.2 2005/01/15 00:36:37 drh Exp $
 
 set testdir [file dirname $argv0]
 source $testdir/tester.tcl
 
+# All the tests in this file require trigger support
+#
+ifcapable {trigger} {
+
 # Create a table and a corresponding insert trigger.  Do a self-insert
 # into the table.
 #
@@ -94,4 +98,35 @@ do_test insert3-2.2 {
   }
 } {1 b c -1 987 c -1 b 876}
 
+# Test for proper detection of malformed WHEN clauses on INSERT triggers.
+#
+do_test insert3-3.1 {
+  execsql {
+    CREATE TABLE t3(a,b,c);
+    CREATE TRIGGER t3r1 BEFORE INSERT on t3 WHEN nosuchcol BEGIN
+      SELECT 'illegal WHEN clause';
+    END;
+  }
+} {}
+do_test insert3-3.2 {
+  catchsql {
+    INSERT INTO t3 VALUES(1,2,3)
+  }
+} {1 {no such column: nosuchcol}}
+do_test insert3-3.3 {
+  execsql {
+    CREATE TABLE t4(a,b,c);
+    CREATE TRIGGER t4r1 AFTER INSERT on t4 WHEN nosuchcol BEGIN
+      SELECT 'illegal WHEN clause';
+    END;
+  }
+} {}
+do_test insert3-3.4 {
+  catchsql {
+    INSERT INTO t4 VALUES(1,2,3)
+  }
+} {1 {no such column: nosuchcol}}
+
+} ;# ifcapable {trigger}
+
 finish_test