From: Matthias Fetzer Date: Tue, 3 Sep 2024 17:27:56 +0000 (+0200) Subject: platform/x86: thinkpad_acpi: Fix uninitialized symbol 's' warning X-Git-Tag: v6.12-rc1~131^2~18 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3a1fb526c2482b2f61c9813e9e14fcdab4ffa390;p=thirdparty%2Fkernel%2Flinux.git platform/x86: thinkpad_acpi: Fix uninitialized symbol 's' warning When the TPACPI_FAN_WR_ACPI_FANW branch is taken s stays uninitialized and would be later used in a debug print. Since the registers are always set to the same two static values inside the branch s is initialized to 0. Fixes: 57d0557dfa49 ("platform/x86: thinkpad_acpi: Add Thinkpad Edge E531 fan support") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/platform-driver-x86/f99e558d-c62a-41eb-93b3-cf00c016d907@stanley.mountain/ Signed-off-by: Matthias Fetzer Link: https://lore.kernel.org/r/20240903172756.19235-1-kontakt@matthias-fetzer.de Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede --- diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 8f70539208843..4c1b0553f8720 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -8318,7 +8318,7 @@ static int fan_set_level_safe(int level) static int fan_set_enable(void) { - u8 s; + u8 s = 0; int rc; if (!fan_control_allowed)