From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 26 Jan 2023 00:02:35 +0000 (-0800)
Subject: tools: ynl: store ops in ordered dict to avoid random ordering
X-Git-Tag: v6.3-rc1~162^2~200^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3a43ded081f862aa2f66a8f4f6630a45a9081e58;p=thirdparty%2Flinux.git

tools: ynl: store ops in ordered dict to avoid random ordering

When rendering code we should walk the ops in the order in which
they are declared in the spec. This is both more intuitive and
prevents code from jumping around when hashing in the dict changes.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/tools/net/ynl/ynl-gen-c.py b/tools/net/ynl/ynl-gen-c.py
index 9297cfacbe065..1aa872e582abc 100755
--- a/tools/net/ynl/ynl-gen-c.py
+++ b/tools/net/ynl/ynl-gen-c.py
@@ -1,6 +1,7 @@
 #!/usr/bin/env python
 
 import argparse
+import collections
 import jsonschema
 import os
 import yaml
@@ -793,7 +794,7 @@ class Family:
         # list of all operations
         self.msg_list = []
         # dict of operations which have their own message type (have attributes)
-        self.ops = dict()
+        self.ops = collections.OrderedDict()
         self.attr_sets = dict()
         self.attr_sets_list = []