From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 15 Oct 2018 18:01:38 +0000 (-0400)
Subject: Check for stack overrun in standard_ProcessUtility().
X-Git-Tag: REL9_3_25~21
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3a60c8bb1698ddde56ee2a0749c75aa1399556fc;p=thirdparty%2Fpostgresql.git

Check for stack overrun in standard_ProcessUtility().

ProcessUtility can recurse, and indeed can be driven to infinite
recursion, so it ought to have a check_stack_depth() call.  This
covers the reported bug (portal trying to execute itself) and a bunch
of other cases that could perhaps arise somewhere.

Per bug #15428 from Malthe Borch.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/15428-b3c2915ec470b033@postgresql.org
---

diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c
index 4640225dd48..ca36572cd36 100644
--- a/src/backend/tcop/utility.c
+++ b/src/backend/tcop/utility.c
@@ -332,6 +332,9 @@ standard_ProcessUtility(Node *parsetree,
 {
 	bool		isTopLevel = (context == PROCESS_UTILITY_TOPLEVEL);
 
+	/* This can recurse, so check for excessive recursion */
+	check_stack_depth();
+
 	check_xact_readonly(parsetree);
 
 	if (completionTag)