From: Chen Ni Date: Tue, 25 Mar 2025 08:49:39 +0000 (+0800) Subject: ALSA: hda: tas2781-i2c: Remove unnecessary NULL check before release_firmware() X-Git-Tag: v6.15-rc1~173^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3a949fc08103c0ce3a1d0ef30459c7b3acc6a214;p=thirdparty%2Flinux.git ALSA: hda: tas2781-i2c: Remove unnecessary NULL check before release_firmware() release_firmware() checks for NULL pointers internally. Remove unneeded NULL check for fmw here. Signed-off-by: Chen Ni Link: https://patch.msgid.link/20250325084939.801117-1-nichen@iscas.ac.cn Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c index 50c5e5f265895..9ed49b0dbe6bc 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -753,8 +753,7 @@ static void tasdev_fw_ready(const struct firmware *fmw, void *context) out: mutex_unlock(&tas_hda->priv->codec_lock); - if (fmw) - release_firmware(fmw); + release_firmware(fmw); pm_runtime_mark_last_busy(tas_hda->dev); pm_runtime_put_autosuspend(tas_hda->dev); }