From: Michael Tremer <michael.tremer@ipfire.org>
Date: Sun, 14 Jan 2018 17:58:17 +0000 (+0100)
Subject: libpakfire: Fix refcounting error in packagelist
X-Git-Tag: 0.9.28~1285^2~1201
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3a96caf29afc3700868557c36ce4986992dfa5c9;p=pakfire.git

libpakfire: Fix refcounting error in packagelist

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/packagelist.c b/src/libpakfire/packagelist.c
index bdee00e34..1b33ec645 100644
--- a/src/libpakfire/packagelist.c
+++ b/src/libpakfire/packagelist.c
@@ -81,14 +81,14 @@ PAKFIRE_EXPORT int pakfire_packagelist_has(PakfirePackageList list, PakfirePacka
 
 PAKFIRE_EXPORT void pakfire_packagelist_push(PakfirePackageList list, PakfirePackage pkg) {
 	list->elements = solv_extend(list->elements, list->count, 1, sizeof(pkg), BLOCK_SIZE);
-	list->elements[list->count++] = pkg;
+	list->elements[list->count++] = pakfire_package_ref(pkg);
 }
 
 PAKFIRE_EXPORT void pakfire_packagelist_push_if_not_exists(PakfirePackageList list, PakfirePackage pkg) {
 	if (pakfire_packagelist_has(list, pkg))
 		return;
 
-	pakfire_packagelist_push(list, pakfire_package_ref(pkg));
+	pakfire_packagelist_push(list, pkg);
 }
 
 PAKFIRE_EXPORT PakfirePackageList pakfire_packagelist_from_queue(PakfirePool _pool, Queue* q) {