From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Thu, 19 Oct 2023 13:59:34 +0000 (-0400)
Subject: fix 1.4 test suite
X-Git-Tag: rel_1_4_50~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3ac3f074266f85694de8b2a73d2f93968554004f;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

fix 1.4 test suite

add some recent fixes so we can get new 1.4 fixes merged

Change-Id: I692c8adb6b22f10629b9d797c1a64334d43f13b3
---

diff --git a/test/dialect/postgresql/test_reflection.py b/test/dialect/postgresql/test_reflection.py
index f33b3bde45..807ea12819 100644
--- a/test/dialect/postgresql/test_reflection.py
+++ b/test/dialect/postgresql/test_reflection.py
@@ -303,13 +303,18 @@ class MaterializedViewReflectionTest(
 
     def test_get_view_definition(self, connection):
         insp = inspect(connection)
+
+        def normalize(definition):
+            # pg16 returns "SELECT" without qualifying tablename.
+            # older pgs include it
+            definition = re.sub(
+                r"testtable\.(\w+)", lambda m: m.group(1), definition
+            )
+            return re.sub(r"[\n\t ]+", " ", definition.strip())
+
         eq_(
-            re.sub(
-                r"[\n\t ]+",
-                " ",
-                insp.get_view_definition("test_mview").strip(),
-            ),
-            "SELECT testtable.id, testtable.data FROM testtable;",
+            normalize(insp.get_view_definition("test_mview")),
+            "SELECT id, data FROM testtable;",
         )
 
 
diff --git a/test/orm/inheritance/test_basic.py b/test/orm/inheritance/test_basic.py
index 9daafb7cef..e2348bb8a4 100644
--- a/test/orm/inheritance/test_basic.py
+++ b/test/orm/inheritance/test_basic.py
@@ -171,6 +171,7 @@ class ColExpressionsTest(fixtures.DeclarativeMappedTest):
         rows = (
             s.query(B.id.expressions[0], B.id.expressions[1], func.sum(B.data))
             .group_by(*B.id.expressions)
+            .order_by(B.id.expressions[0])
             .all()
         )
         eq_(rows, [(1, 1, 5), (2, 2, 7)])