From: Willy Tarreau <w@1wt.eu>
Date: Tue, 18 Dec 2018 13:34:41 +0000 (+0100)
Subject: BUG/MINOR: mux-h2: don't report a fantom h2s in "show fd"
X-Git-Tag: v1.9.0~34
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3af3771bf3cdb6639565f186dc857202fb7ca0bf;p=thirdparty%2Fhaproxy.git

BUG/MINOR: mux-h2: don't report a fantom h2s in "show fd"

The h2s pointer was used to scan fctl lists prior to being used to scan
the send list by ID, so it could appear non-null eventhough the list is
empty, resulting in misleading information on empty connections.

No backport is needed.
---

diff --git a/src/mux_h2.c b/src/mux_h2.c
index 33510dcab5..58a0521742 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -4860,6 +4860,7 @@ static void h2_show_fd(struct buffer *msg, struct connection *conn)
 	list_for_each_entry(h2s, &h2c->send_list, list)
 		send_cnt++;
 
+	h2s = NULL;
 	node = eb32_first(&h2c->streams_by_id);
 	while (node) {
 		h2s = container_of(node, struct h2s, by_id);