From: Willy Tarreau <w@1wt.eu>
Date: Wed, 16 Sep 2020 14:24:14 +0000 (+0200)
Subject: BUG/MEDIUM: log-forward: always quit on parsing errors
X-Git-Tag: v2.3-dev5~88
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3b139e540aac5e2f2801d920be1c3c757ae33a8f;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: log-forward: always quit on parsing errors

The err_code and goto were misplaced, causing a fatal parse error to be
ignored when parsing a UDP listener's address. No backport is needed.
---

diff --git a/src/log.c b/src/log.c
index 984a31a262..5f71bfe35f 100644
--- a/src/log.c
+++ b/src/log.c
@@ -3630,9 +3630,9 @@ int cfg_parse_log_forward(const char *file, int linenum, char **args, int kwm)
 			else {
 				ha_alert("parsing [%s:%d] : '%s %s' : error encountered while parsing listening address %s.\n",
 				         file, linenum, args[0], args[1], args[2]);
-				err_code |= ERR_ALERT | ERR_FATAL;
-				goto out;
 			}
+			err_code |= ERR_ALERT | ERR_FATAL;
+			goto out;
 		}
 		list_for_each_entry(l, &bind_conf->listeners, by_bind) {
 			/* Currently, only UDP handlers are allowed */