From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Thu, 15 Aug 2024 11:24:36 +0000 (+0300)
Subject: scsi: ufs: ufshcd-pltfrm: Signedness bug in ufshcd_parse_clock_info()
X-Git-Tag: v6.12-rc1~124^2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3ba963597d19d88eb06b50af8e8757abbdc9035b;p=thirdparty%2Fkernel%2Flinux.git

scsi: ufs: ufshcd-pltfrm: Signedness bug in ufshcd_parse_clock_info()

The "sz" variable needs to be a signed type for the error handling to work
as intended.  Fortunately, there is some sanity checking on "sz" on the
next line, so negative values would be caught and it doesn't really affect
runtime.

Fixes: eab0dce11dd9 ("scsi: ufs: ufshcd-pltfrm: Use of_property_count_u32_elems() to get property length")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/404a4727-89c6-410b-9ece-301fa399d4db@stanley.mountain
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c
index 0c9b303ccfa0e..1f4f30d6cb423 100644
--- a/drivers/ufs/host/ufshcd-pltfrm.c
+++ b/drivers/ufs/host/ufshcd-pltfrm.c
@@ -31,7 +31,7 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba)
 	const char *name;
 	u32 *clkfreq = NULL;
 	struct ufs_clk_info *clki;
-	size_t sz = 0;
+	ssize_t sz = 0;
 
 	if (!np)
 		goto out;